spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] Nibooor commented on a change in pull request #26598: [SPARK-29861][CORE] Reduce downtime in Spark standalone HA master switch
Date Tue, 19 Nov 2019 18:30:39 GMT
Nibooor commented on a change in pull request #26598: [SPARK-29861][CORE] Reduce downtime in
Spark standalone HA master switch
URL: https://github.com/apache/spark/pull/26598#discussion_r348095679
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/master/ZookeeperSuspensionTolerantErrorPolicy.scala
 ##########
 @@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.deploy.master
+
+import org.apache.curator.framework.state.ConnectionState
+import org.apache.curator.framework.state.ConnectionStateErrorPolicy
 
 Review comment:
   Hi, 
   
   yes this happens in my local environment now as well (I cherry-picked this from a 2.2 branch
before).
   
   The issue is caused because according to the build logs `curator-client-2.13.0.jar` is
added to the core classpath by `maven-dependency-plugin:3.1.1` instead of the desired version
`4.2.0`.
   
   Strangely `./build/mvn dependency:tree` lists only the correct versions (`4.2.0`) on curator
everywhere...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message