spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] WangGuangxin commented on a change in pull request #26548: [SPARK-29918][SQL] RecordBinaryComparator should check endianness when compared by long
Date Mon, 18 Nov 2019 15:30:52 GMT
WangGuangxin commented on a change in pull request #26548: [SPARK-29918][SQL] RecordBinaryComparator
should check endianness when compared by long
URL: https://github.com/apache/spark/pull/26548#discussion_r347446272
 
 

 ##########
 File path: sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
 ##########
 @@ -321,4 +321,69 @@ public void testBinaryComparatorWhenOnlyTheLastColumnDiffers() throws
Exception
 
     assert(compare(0, 1) < 0);
   }
+
+  @Test
+  public void testBinaryComparatorGiveSameResultWhenComparedByteByByteAndComparedByLong()
+      throws Exception {
+    int numFields = 1;
+
+    UnsafeRow row1 = new UnsafeRow(numFields);
 
 Review comment:
   test cast updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message