spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] srowen commented on a change in pull request #26548: [SPARK-29918][SQL] RecordBinaryComparator should check endianness when compared by long
Date Mon, 18 Nov 2019 14:34:08 GMT
srowen commented on a change in pull request #26548: [SPARK-29918][SQL] RecordBinaryComparator
should check endianness when compared by long
URL: https://github.com/apache/spark/pull/26548#discussion_r347411823
 
 

 ##########
 File path: sql/core/src/main/java/org/apache/spark/sql/execution/RecordBinaryComparator.java
 ##########
 @@ -22,6 +22,12 @@
 
 public final class RecordBinaryComparator extends RecordComparator {
 
+  boolean isLittlenEndian;
+
+  public RecordBinaryComparator(boolean isLittlenEndian) {
 
 Review comment:
   No need for this. It's a fixed property of the entire VM / JVM. Just:
   `private static final boolean LITTLE_ENDIAN = ByteOrder.nativeOrder.equals(ByteOrder.LITTLE_ENDIAN);`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message