spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #26562: [SPARK-29859][SQL] ALTER DATABASE (SET LOCATION) should look up catalog like v2 commands
Date Mon, 18 Nov 2019 04:01:44 GMT
cloud-fan commented on a change in pull request #26562: [SPARK-29859][SQL] ALTER DATABASE (SET
LOCATION) should look up catalog like v2 commands
URL: https://github.com/apache/spark/pull/26562#discussion_r347194089
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
 ##########
 @@ -96,6 +96,9 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
     case AlterNamespaceSetPropertiesStatement(NonSessionCatalog(catalog, nameParts), properties)
=>
       AlterNamespaceSetProperties(catalog, nameParts, properties)
 
+    case AlterNamespaceSetLocationStatement(NonSessionCatalog(catalog, nameParts), location)
=>
+      AlterNamespaceSetLocation(catalog, nameParts, location)
 
 Review comment:
   Yea, these special properties need to be recognized by implementations as well. I think
we should define them as static variables in `Table` and `SupportsNamespaces`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message