spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] gaborgsomogyi commented on a change in pull request #26416: [WIP][SPARK-29779][CORE] Compact old event log files and cleanup
Date Wed, 13 Nov 2019 12:42:34 GMT
gaborgsomogyi commented on a change in pull request #26416: [WIP][SPARK-29779][CORE] Compact
old event log files and cleanup
URL: https://github.com/apache/spark/pull/26416#discussion_r345737122
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala
 ##########
 @@ -218,12 +219,24 @@ class RollingEventLogFilesFileReader(
 
   private lazy val eventLogFiles: Seq[FileStatus] = {
     val eventLogFiles = files.filter(isEventLogFile).sortBy { status =>
-      getIndex(status.getPath.getName)
+      val filePath = status.getPath
+      var idx = getIndex(status.getPath.getName) + 0.0d
 
 Review comment:
   Maybe `.toDouble` then to spare an addition?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message