spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite
Date Wed, 13 Nov 2019 11:26:25 GMT
cloud-fan commented on a change in pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import`
directive to load queries from another test case in SQLQueryTestSuite
URL: https://github.com/apache/spark/pull/26497#discussion_r345706071
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/ansi/decimalArithmeticOperations.sql
 ##########
 @@ -0,0 +1,2 @@
+-- throw an exception instead of returning NULL, according to SQL ANSI 2011
 
 Review comment:
   can we add a little more description? when will we throw an exception?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message