spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] huaxingao commented on a change in pull request #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover should support multi-cols
Date Tue, 12 Nov 2019 05:58:16 GMT
huaxingao commented on a change in pull request #26480: [SPARK-29808][ML][PYTHON] StopWordsRemover
should support multi-cols
URL: https://github.com/apache/spark/pull/26480#discussion_r345028011
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala
 ##########
 @@ -51,6 +57,14 @@ class StopWordsRemover @Since("1.5.0") (@Since("1.5.0") override val uid:
String
   @Since("1.5.0")
   def setOutputCol(value: String): this.type = set(outputCol, value)
 
+  /** @group setParam */
+  @Since("3.0.0")
+  def setInputCols(value: Array[String]): this.type = set(inputCols, value)
+
+  /** @group setParam */
+  @Since("3.0.0")
+  def setOutputCols(value: Array[String]): this.type = set(outputCols, value)
+
 
 Review comment:
   I am debating if I should add ```stopWordsArray/caseSensitiveArray/localArray```. Seems
to me that users will use the same set of ```stopWords``` for all columns, so it's no need
to add those. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message