spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect: cast to boolean
Date Tue, 12 Nov 2019 03:31:26 GMT
cloud-fan commented on a change in pull request #26463: [SPARK-29837][SQL] PostgreSQL dialect:
cast to boolean
URL: https://github.com/apache/spark/pull/26463#discussion_r345004218
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/PostgreSQLDialectQuerySuite.scala
 ##########
 @@ -36,7 +36,8 @@ class PostgreSQLDialectQuerySuite extends QueryTest with SharedSparkSession
{
     }
 
     Seq("o", "abc", "").foreach { input =>
-      checkAnswer(sql(s"select cast('$input' as boolean)"), Row(null))
+      intercept[IllegalArgumentException](
+        checkAnswer(sql(s"select cast('$input' as boolean)"), Row(null)))
 
 Review comment:
   since we expect error here, we can just run `sql(s"select cast('$input' as boolean)").collect`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message