spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] yaooqinn commented on a change in pull request #26449: [SPARK-29822][SQL] Fix cast error when there are white spaces between signs and values
Date Mon, 11 Nov 2019 07:16:18 GMT
yaooqinn commented on a change in pull request #26449: [SPARK-29822][SQL] Fix cast error when
there are white spaces between signs and values
URL: https://github.com/apache/spark/pull/26449#discussion_r344581845
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
 ##########
 @@ -425,11 +425,15 @@ object IntervalUtils {
   }
 
   private object ParseState extends Enumeration {
+    type ParseState = Value
+
     val PREFIX,
         BEGIN_VALUE,
 
 Review comment:
   interval (PREFIX,  BODY)
   BODY (SIGN,  VALUE , UNIT)+
   
   Seems not  persuadable enough

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message