spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] tgravescs commented on a change in pull request #26440: [WIP][SPARK-20628][CORE] Start to improve Spark decommissioning & preemption support
Date Fri, 08 Nov 2019 22:01:26 GMT
tgravescs commented on a change in pull request #26440: [WIP][SPARK-20628][CORE] Start to improve
Spark decommissioning & preemption support
URL: https://github.com/apache/spark/pull/26440#discussion_r344379161
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
 ##########
 @@ -71,6 +72,9 @@ private[spark] class CoarseGrainedExecutorBackend(
   private[executor] val taskResources = new mutable.HashMap[Long, Map[String, ResourceInformation]]
 
   override def onStart(): Unit = {
+    logInfo("Registering PWR handler.")
+    SignalUtils.register("PWR")(decommissionSelf)
 
 Review comment:
   is there an application level config to enable decommissioning?  For instance YARN doesn't
need this if YARN is telling the driver

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message