spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #26392: [WIP][SPARK-29750][BUILD] Avoid dependency from joda-time
Date Tue, 05 Nov 2019 06:15:39 GMT
dongjoon-hyun commented on a change in pull request #26392: [WIP][SPARK-29750][BUILD] Avoid
dependency from joda-time
URL: https://github.com/apache/spark/pull/26392#discussion_r342395274
 
 

 ##########
 File path: dev/deps/spark-deps-hadoop-2.7
 ##########
 @@ -125,7 +125,6 @@ jetty-6.1.26.jar
 jetty-sslengine-6.1.26.jar
 jetty-util-6.1.26.jar
 jline-2.14.6.jar
-joda-time-2.10.5.jar
 
 Review comment:
   Instead of this, `joda-time-2.9.9.jar` seems to occur transitively. Could you check the
dependency tree and remove that, too?
   ```
   +++ b/dev/pr-deps/spark-deps-hadoop-2.7
   @@ -125,6 +125,7 @@ jetty-6.1.26.jar
    jetty-sslengine-6.1.26.jar
    jetty-util-6.1.26.jar
    jline-2.14.6.jar
   +joda-time-2.9.9.jar
    jodd-core-3.5.2.jar
    jpam-1.1.jar
    json4s-ast_2.12-3.6.6.jar
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message