spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] MaxGekk commented on a change in pull request #26337: [SPARK-29679][SQL] Make interval type comparable and orderable
Date Tue, 05 Nov 2019 05:50:37 GMT
MaxGekk commented on a change in pull request #26337: [SPARK-29679][SQL] Make interval type
comparable and orderable
URL: https://github.com/apache/spark/pull/26337#discussion_r342390659
 
 

 ##########
 File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
 ##########
 @@ -78,6 +81,27 @@ public int hashCode() {
     return Objects.hash(months, days, microseconds);
   }
 
+  @Override
+  public int compare(CalendarInterval that) {
+    long thisAdjustDays = this.microseconds / MICROS_PER_DAY + this.days + this.months *
30;
 
 Review comment:
   How about to extract the code:
   ```scala
      var result = interval.microseconds 
      result += DateTimeUtils.MICROS_PER_DAY * interval.days 
      result += MICROS_PER_YEAR * (interval.months / MONTHS_PER_YEAR) 
      result += MICROS_PER_MONTH * (interval.months % MONTHS_PER_YEAR)
   ```
   and reuse it in the comparison? At least, we will have consistent behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message