spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] viirya commented on a change in pull request #26330: [WIP][SPARK-29672][PYSPARK] DO NOT MERGE -- remove py27 support for jenkins tests
Date Fri, 01 Nov 2019 23:09:20 GMT
viirya commented on a change in pull request #26330: [WIP][SPARK-29672][PYSPARK] DO NOT MERGE
-- remove py27 support for jenkins tests
URL: https://github.com/apache/spark/pull/26330#discussion_r341779428
 
 

 ##########
 File path: python/run-tests.py
 ##########
 @@ -160,11 +164,33 @@ def run_individual_python_test(target_dir, test_name, pyspark_python):
 
 
 def get_default_python_executables():
-    python_execs = [x for x in ["python2.7", "python3.6", "pypy"] if which(x)]
-    if "python2.7" not in python_execs:
-        LOGGER.warning("Not testing against `python2.7` because it could not be found; falling"
-                       " back to `python` instead")
-        python_execs.insert(0, "python")
+    python_execs = [x for x in ["python3.6", "pypy"] if which(x)]
+
+    if "python3.6" not in python_execs:
+        p = which("python3")
+
+        if p:
+            py_out = subprocess.run([p, "--version"], stderr=subprocess.PIPE)
+            py_out = py_out.stderr.decode("utf-8")
 
 Review comment:
   why it is stderr? I ran with this change, stdout works but stderr not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message