From reviews-return-951508-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue Oct 29 04:44:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 343A4180638 for ; Tue, 29 Oct 2019 05:44:14 +0100 (CET) Received: (qmail 34309 invoked by uid 500); 29 Oct 2019 04:44:13 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 34297 invoked by uid 99); 29 Oct 2019 04:44:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Oct 2019 04:44:13 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] huaxingao commented on a change in pull request #26265: [SPARK-29565][ML][PYTHON] OneHotEncoder should support single-column input/output Message-ID: <157232425338.27750.7096820307413315091.gitbox@gitbox.apache.org> Date: Tue, 29 Oct 2019 04:44:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit huaxingao commented on a change in pull request #26265: [SPARK-29565][ML][PYTHON] OneHotEncoder should support single-column input/output URL: https://github.com/apache/spark/pull/26265#discussion_r339892325 ########## File path: mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala ########## @@ -123,6 +132,14 @@ class OneHotEncoder @Since("3.0.0") (@Since("3.0.0") override val uid: String) @Since("3.0.0") def this() = this(Identifiable.randomUID("oneHotEncoder")) + /** @group setParam */ + @Since("3.0.0") + def setInputCol(values: String): this.type = set(inputCol, values) + + /** @group setParam */ + @Since("3.0.0") + def setOutputCol(values: String): this.type = set(outputCol, values) Review comment: updated. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org