From reviews-return-948185-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Oct 24 17:33:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 243A818065D for ; Thu, 24 Oct 2019 19:33:46 +0200 (CEST) Received: (qmail 50797 invoked by uid 500); 24 Oct 2019 17:33:45 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 50786 invoked by uid 99); 24 Oct 2019 17:33:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Oct 2019 17:33:45 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] dongjoon-hyun commented on a change in pull request #26137: [SPARK-29490][SQL] Reset 'WritableColumnVector' in 'RowToColumnarExec' Message-ID: <157193842542.4898.12140270602155674476.gitbox@gitbox.apache.org> Date: Thu, 24 Oct 2019 17:33:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dongjoon-hyun commented on a change in pull request #26137: [SPARK-29490][SQL] Reset 'WritableColumnVector' in 'RowToColumnarExec' URL: https://github.com/apache/spark/pull/26137#discussion_r338701803 ########## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala ########## @@ -171,6 +172,30 @@ class SparkSessionExtensionSuite extends SparkFunSuite { } } + test("reset column vectors") { Review comment: Thank you for your first contribution, @rongma1997 . For the bug fix test case, we need `SPARK-29490` prefix for the test case name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org