From reviews-return-948117-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Oct 24 15:14:18 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C593118065D for ; Thu, 24 Oct 2019 17:14:17 +0200 (CEST) Received: (qmail 32684 invoked by uid 500); 24 Oct 2019 15:14:17 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 32673 invoked by uid 99); 24 Oct 2019 15:14:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Oct 2019 15:14:17 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] cloud-fan commented on a change in pull request #25919: [WIP][SPARK-15616][SQL] Hive table supports partition pruning in JoinSelection Message-ID: <157193005710.7963.14661826516108080748.gitbox@gitbox.apache.org> Date: Thu, 24 Oct 2019 15:14:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cloud-fan commented on a change in pull request #25919: [WIP][SPARK-15616][SQL] Hive table supports partition pruning in JoinSelection URL: https://github.com/apache/spark/pull/25919#discussion_r338633807 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ########## @@ -610,7 +610,10 @@ case class HiveTableRelation( tableMeta: CatalogTable, dataCols: Seq[AttributeReference], partitionCols: Seq[AttributeReference], - tableStats: Option[Statistics] = None) extends LeafNode with MultiInstanceRelation { + tableStats: Option[Statistics] = None, + @transient normalizedFilters: Seq[Expression] = Nil, + @transient prunedPartitions: Seq[CatalogTablePartition] = Nil) Review comment: How can we distinguish 0 partitions after pruning, and not being partition pruned? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org