From reviews-return-946447-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Oct 23 07:07:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 53A82180660 for ; Wed, 23 Oct 2019 09:07:55 +0200 (CEST) Received: (qmail 95129 invoked by uid 500); 23 Oct 2019 07:07:54 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 95078 invoked by uid 99); 23 Oct 2019 07:07:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Oct 2019 07:07:54 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] MaxGekk commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing Message-ID: <157181447462.15341.4365221274026628685.gitbox@gitbox.apache.org> Date: Wed, 23 Oct 2019 07:07:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit MaxGekk commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#discussion_r337876466 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala ########## @@ -88,4 +91,24 @@ object IntervalUtils { result += MICROS_PER_MONTH * (interval.months % MONTHS_PER_YEAR) Decimal(result, 18, 6) } + + def fromString(str: String): CalendarInterval = { + if (str == null) throw new IllegalArgumentException("Interval string cannot be null") + try { + CatalystSqlParser.parseInterval(str) + } catch { + case e: ParseException => Review comment: `case NonFatal(e) =>`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org