From reviews-return-943842-archive-asf-public=cust-asf.ponee.io@spark.apache.org Mon Oct 21 02:40:43 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5C059180629 for ; Mon, 21 Oct 2019 04:40:43 +0200 (CEST) Received: (qmail 19390 invoked by uid 500); 21 Oct 2019 02:40:42 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 19379 invoked by uid 99); 21 Oct 2019 02:40:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Oct 2019 02:40:42 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] cloud-fan commented on a change in pull request #26182: [SPARK-29523][SQL] SHOW COLUMNS should do multi-catalog resolution. Message-ID: <157162564266.12392.597875168143996901.gitbox@gitbox.apache.org> Date: Mon, 21 Oct 2019 02:40:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cloud-fan commented on a change in pull request #26182: [SPARK-29523][SQL] SHOW COLUMNS should do multi-catalog resolution. URL: https://github.com/apache/spark/pull/26182#discussion_r336821230 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ########## @@ -2728,4 +2728,19 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging override def visitRepairTable(ctx: RepairTableContext): LogicalPlan = withOrigin(ctx) { RepairTableStatement(visitMultipartIdentifier(ctx.multipartIdentifier())) } + + /** + * A command for users to list the column names for a table. + * This function creates a [[ShowColumnsStatement]] logical plan. + * + * The syntax of using this command in SQL is: + * {{{ + * SHOW COLUMNS (FROM | IN) multi_part_name [(FROM | IN) database]; Review comment: The syntax should be ` SHOW COLUMNS [(FROM | IN) multi_part_name]` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org