From reviews-return-943412-archive-asf-public=cust-asf.ponee.io@spark.apache.org Sat Oct 19 20:53:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A4918180654 for ; Sat, 19 Oct 2019 22:53:07 +0200 (CEST) Received: (qmail 25514 invoked by uid 500); 19 Oct 2019 20:53:07 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 25503 invoked by uid 99); 19 Oct 2019 20:53:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Oct 2019 20:53:07 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] MaxGekk commented on a change in pull request #26134: [SPARK-29486][SQL] CalendarInterval should have 3 fields: months, days and microseconds Message-ID: <157151838686.9215.9354807882867652706.gitbox@gitbox.apache.org> Date: Sat, 19 Oct 2019 20:53:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit MaxGekk commented on a change in pull request #26134: [SPARK-29486][SQL] CalendarInterval should have 3 fields: months, days and microseconds URL: https://github.com/apache/spark/pull/26134#discussion_r336753474 ########## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ########## @@ -731,7 +731,7 @@ class Dataset[T] private[sql]( s"Unable to parse time delay '$delayThreshold'", cause = Some(e)) } - require(parsedDelay.milliseconds >= 0 && parsedDelay.months >= 0, + require(parsedDelay.milliseconds >= 0 && parsedDelay.days >= 0 && parsedDelay.months >= 0, Review comment: The PR https://github.com/apache/spark/pull/26177 to fix this ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org