spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] srowen commented on issue #26332: [SPARK-29674][CORE] Update dropwizard metrics to 4.1.x for JDK 9+
Date Thu, 31 Oct 2019 00:52:38 GMT
srowen commented on issue #26332: [SPARK-29674][CORE] Update dropwizard metrics to 4.1.x for
JDK 9+
URL: https://github.com/apache/spark/pull/26332#issuecomment-548172078
 
 
   Oh, wait no I see the issue. Ganglia support is in a different module that I didn't enable.
Indeed it isn't present in 4.x: https://search.maven.org/search?q=g:io.dropwizard.metrics%20AND%20a:metrics-ganglia&core=gav
   
   Hm, OK, that's a problem, as we have historically maintained some Ganglia support.
   But there are actually no tests for this integration, so we wouldn't have noticed any issues
with it anyway.
   
   Maybe I need to take this to dev@ ... if the support doesn't necessarily work on JDK 11
(unproven) then do we need to consider removing it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message