spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #26231: [SPARK-29572][SQL] add v1 read fallback API in DS v2
Date Wed, 30 Oct 2019 18:20:45 GMT
dongjoon-hyun commented on a change in pull request #26231: [SPARK-29572][SQL] add v1 read
fallback API in DS v2
URL: https://github.com/apache/spark/pull/26231#discussion_r340784586
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
 ##########
 @@ -42,7 +43,7 @@ object DataSourceV2Strategy extends Strategy with PredicateHelper {
    */
   private def pushFilters(
       scanBuilder: ScanBuilder,
-      filters: Seq[Expression]): (Seq[Expression], Seq[Expression]) = {
+      filters: Seq[Expression]): (Seq[Filter], Seq[Expression]) = {
 
 Review comment:
   cc @dbtsai since this is related to his on-going nested column filter work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message