spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO in the parser and add the corresponding logical plan
Date Wed, 30 Oct 2019 13:52:13 GMT
cloud-fan commented on a change in pull request #26167: [SPARK-28893][SQL] Support MERGE INTO
in the parser and add the corresponding logical plan
URL: https://github.com/apache/spark/pull/26167#discussion_r340625406
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala
 ##########
 @@ -246,6 +246,31 @@ case class UpdateTableStatement(
     values: Seq[Expression],
     condition: Option[Expression]) extends ParsedStatement
 
+/**
+ * A MERGE INTO tbl_name statement, as parsed from SQL.
+ */
+case class MergeIntoStatement(
 
 Review comment:
   do we really need a statement for v2 only commands? It looks to me that this only creates
code duplication without any benefit. cc @rdblue 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message