spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] huaxingao commented on a change in pull request #26265: [SPARK-29565][ML][PYTHON] OneHotEncoder should support single-column input/output
Date Tue, 29 Oct 2019 04:44:13 GMT
huaxingao commented on a change in pull request #26265: [SPARK-29565][ML][PYTHON] OneHotEncoder
should support single-column input/output
URL: https://github.com/apache/spark/pull/26265#discussion_r339892325
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala
 ##########
 @@ -123,6 +132,14 @@ class OneHotEncoder @Since("3.0.0") (@Since("3.0.0") override val uid:
String)
   @Since("3.0.0")
   def this() = this(Identifiable.randomUID("oneHotEncoder"))
 
+  /** @group setParam */
+  @Since("3.0.0")
+  def setInputCol(values: String): this.type = set(inputCol, values)
+
+  /** @group setParam */
+  @Since("3.0.0")
+  def setOutputCol(values: String): this.type = set(outputCol, values)
 
 Review comment:
   updated. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message