spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] shahidki31 commented on a change in pull request #26259: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
Date Sat, 26 Oct 2019 18:36:02 GMT
shahidki31 commented on a change in pull request #26259: [SPARK-29453][WEBUI] Improve tooltips
information for SQL tab.
URL: https://github.com/apache/spark/pull/26259#discussion_r339310780
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
 ##########
 @@ -397,9 +408,16 @@ private[ui] class ExecutionPagedTable(
 
     val desc = if (execution.description != null && execution.description.nonEmpty)
{
       <a href={executionURL(execution.executionId)} class="description-input">
-        {execution.description}</a>
+        <span
+        data-toggle="tooltip" data-placement="top" title="Click to navigate query details
page.">
+          {execution.description}
+        </span></a>
 
 Review comment:
   We already added the tooltip in headers. Right? Is it necessary to add in every row, the
same information?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message