spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] wenxuanguan commented on a change in pull request #25914: [SPARK-29227][SS] Track rule info in optimization phase
Date Fri, 25 Oct 2019 07:31:18 GMT
wenxuanguan commented on a change in pull request #25914: [SPARK-29227][SS] Track rule info
in optimization phase
URL: https://github.com/apache/spark/pull/25914#discussion_r338919365
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/QueryPlanningTrackerEndToEndSuite.scala
 ##########
 @@ -38,4 +40,22 @@ class QueryPlanningTrackerEndToEndSuite extends SharedSparkSession {
     assert(tracker.rules.nonEmpty)
   }
 
+  test("SPARK-29227: Track rule info in optimization phase in streaming") {
 
 Review comment:
   > No, @wenxuanguan ~ Only the JIRA ID.
   > 
   > > And also, do you mean add Apache JIRA issue info(prefix and title) in test name
if it is bugfix?
   
   @dongjoon-hyun got it, Thanks a lot.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message