spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #26137: [SPARK-29490][SQL] Reset 'WritableColumnVector' in 'RowToColumnarExec'
Date Thu, 24 Oct 2019 17:33:45 GMT
dongjoon-hyun commented on a change in pull request #26137: [SPARK-29490][SQL] Reset 'WritableColumnVector'
in 'RowToColumnarExec'
URL: https://github.com/apache/spark/pull/26137#discussion_r338701803
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
 ##########
 @@ -171,6 +172,30 @@ class SparkSessionExtensionSuite extends SparkFunSuite {
     }
   }
 
+  test("reset column vectors") {
 
 Review comment:
   Thank you for your first contribution, @rongma1997 .
   For the bug fix test case, we need `SPARK-29490` prefix for the test case name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message