spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] 07ARB commented on a change in pull request #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
Date Wed, 23 Oct 2019 06:23:36 GMT
07ARB commented on a change in pull request #26216: [SPARK-29453][WEBUI] Improve tooltips information
for SQL tab.
URL: https://github.com/apache/spark/pull/26216#discussion_r337867052
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
 ##########
 @@ -296,8 +296,23 @@ private[ui] class ExecutionPagedTable(
 
     require(sortableColumnHeaders.contains(sortColumn), s"Unknown column: $sortColumn")
 
+    def getHeaderTooltips(header: String): String = header match {
 
 Review comment:
   ok i will define as private

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message