spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] 07ARB commented on a change in pull request #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
Date Wed, 23 Oct 2019 06:00:47 GMT
07ARB commented on a change in pull request #26216: [SPARK-29453][WEBUI] Improve tooltips information
for SQL tab.
URL: https://github.com/apache/spark/pull/26216#discussion_r337861526
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
 ##########
 @@ -73,10 +73,35 @@ class AllExecutionsPageSuite extends SharedSparkSession with BeforeAndAfter
{
     map.put("failed.sort", Array("duration"))
     when(request.getParameterMap()).thenReturn(map)
     val html = renderSQLPage(request, tab, statusStore).toString().toLowerCase(Locale.ROOT)
-    assert(!html.contains("IllegalArgumentException"))
+    assert(!html.contains("illegalargumentexception"))
 
 Review comment:
   @shahidki31, No it should be in lowercase because if you see below code there they are
using .toLowerCase(Locale.ROOT) which will convert complete html contain to lowercase. 
   
   val html = renderSQLPage(request, tab, statusStore).toString().toLowerCase(Locale.ROOT)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message