spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] imback82 commented on a change in pull request #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands
Date Mon, 21 Oct 2019 14:32:49 GMT
imback82 commented on a change in pull request #26183: [SPARK-29513][SQL] REFRESH TABLE should
look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26183#discussion_r337052387
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
 ##########
 @@ -282,6 +282,10 @@ class ResolveSessionCatalog(
       AlterTableRecoverPartitionsCommand(
         v1TableName.asTableIdentifier,
         "MSCK REPAIR TABLE")
+
+    case RefreshTableStatement(tableName) =>
+      val v1TableName = parseV1Table(tableName, "REFRESH TABLE")
 
 Review comment:
   Followed by `TableCatalog.loadTable`? Or`TableCatalog.loadTable` is called lazily (you
don't call it inside `RefreshTableExec` - in this case, same behavior as `UNCACHE TABLE`)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message