spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] MaxGekk commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
Date Mon, 21 Oct 2019 14:15:33 GMT
MaxGekk commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
URL: https://github.com/apache/spark/pull/26190#issuecomment-544534832
 
 
   > @MaxGekk I don't think performance is a strong reason to move parsing logic from antlr
to hand-written jave code. It's better to centralize the parsing stuff in antlr.
   
   I would agree with you till Spark support bulk loading of interval strings. Also I think
it doesn't matter for users how do you implement parsing. If two implementation are functionally
equivalent, users would prefer the fastest one, I think. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message