spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #25024: [SPARK-27296][SQL] User Defined Aggregators that do not ser/de on each input row
Date Mon, 21 Oct 2019 08:05:47 GMT
cloud-fan commented on a change in pull request #25024: [SPARK-27296][SQL] User Defined Aggregators
that do not ser/de on each input row
URL: https://github.com/apache/spark/pull/25024#discussion_r336882556
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLContextSuite.scala
 ##########
 @@ -51,7 +51,7 @@ class SQLContextSuite extends SparkFunSuite with SharedSparkContext {
 
     // UDF should not be shared
     def myadd(a: Int, b: Int): Int = a + b
-    session1.udf.register[Int, Int, Int]("myadd", myadd)
+    session1.udf.register[Int, Int, Int]("myadd", myadd(_, _))
 
 Review comment:
   to make our life easier, how about we use `registerAggregator` as the new function name?
 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message