spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] viirya commented on a change in pull request #26164: [SPARK-21492][SQL] Fix memory leak in SortMergeJoin
Date Fri, 18 Oct 2019 20:06:10 GMT
viirya commented on a change in pull request #26164: [SPARK-21492][SQL] Fix memory leak in
SortMergeJoin
URL: https://github.com/apache/spark/pull/26164#discussion_r336656701
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
 ##########
 @@ -161,6 +162,10 @@ case class SortMergeJoinExec(
     sqlContext.conf.sortMergeJoinExecBufferInMemoryThreshold
   }
 
+  private def needEagerCleanup: Boolean = {
+    sqlContext.conf.getConf(SORT_MERGE_JOIN_EXEC_EAGER_CLEANUP_RESOURCES)
 
 Review comment:
   Seems this only controls cleanup behavior in codege path?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message