spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] itskals commented on a change in pull request #25840: [SPARK-29166][SQL] Add parameters to limit the number of dynamic partitions for data source table
Date Mon, 14 Oct 2019 04:08:20 GMT
itskals commented on a change in pull request #25840: [SPARK-29166][SQL] Add parameters to
limit the number of dynamic partitions for data source table
URL: https://github.com/apache/spark/pull/25840#discussion_r334321860
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SQLHadoopMapReduceCommitProtocol.scala
 ##########
 @@ -66,4 +91,37 @@ class SQLHadoopMapReduceCommitProtocol(
     logInfo(s"Using output committer class ${committer.getClass.getCanonicalName}")
     committer
   }
+
+  /**
+   * Called on the driver after a task commits. This can be used to access task commit messages
+   * before the job has finished. These same task commit messages will be passed to commitJob()
+   * if the entire job succeeds.
+   * Override it to check dynamic partition limitation on driver side.
+   */
+  override def onTaskCommit(taskCommit: TaskCommitMessage): Unit = {
 
 Review comment:
   this implementation completely hides org.apache.spark.internal.io.HadoopMapReduceCommitProtocol#commitTask,
which was the behaviour earlier.
   
   Is it intensional?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message