spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #26098: Add configuration to support JacksonGenrator to keep fields with null values
Date Sat, 12 Oct 2019 23:03:12 GMT
dongjoon-hyun commented on a change in pull request #26098: Add configuration to support JacksonGenrator
to keep fields with null values
URL: https://github.com/apache/spark/pull/26098#discussion_r334256168
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonGeneratorSuite.scala
 ##########
 @@ -39,6 +39,18 @@ class JacksonGeneratorSuite extends SparkFunSuite {
     assert(writer.toString === """{"a":1}""")
   }
 
+  test("initial with StructType and write out an empty row with allowStructIncludeNull=true")
{
 
 Review comment:
   This looks like a test case for bug. We need a JIRA issue ID prefix for the test case name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message