spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode
Date Fri, 11 Oct 2019 19:32:20 GMT
dongjoon-hyun commented on a change in pull request #26094: [SPARK-29442][SQL][PYSPARK] Set
`default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#discussion_r334144047
 
 

 ##########
 File path: python/pyspark/sql/readwriter.py
 ##########
 @@ -593,7 +593,7 @@ def mode(self, saveMode):
 
         * `append`: Append contents of this :class:`DataFrame` to existing data.
         * `overwrite`: Overwrite existing data.
-        * `error` or `errorifexists`: Throw an exception if data already exists.
+        * `error`, `errorifexists`, `default`: Throw an exception if data already exists.
 
 Review comment:
   It seems that `PySpark` and `SparkR` API hides this intentionally until now.
   
   @HyukjinKwon . Do we need to update here?
   @felixcheung . Do we need to add `default` mode description to `DataFrame.R`, too?
   
   Although Python seems to have 1 instance, `DataFrame.R` has many instances. `write.json`,
`write.orc`, ...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message