spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] MaxGekk commented on issue #26094: [SPARK-29442][SQL] Set `default` mode should override the existing mode
Date Fri, 11 Oct 2019 18:09:09 GMT
MaxGekk commented on issue #26094: [SPARK-29442][SQL] Set `default` mode should override the
existing mode
URL: https://github.com/apache/spark/pull/26094#issuecomment-541167531
 
 
   I am looking at `DataStreamWriter`, is this `"default"` mode specific to `DataFrameWriter`?
`DataStreamWriter` uses https://github.com/apache/spark/blob/5264164a67df498b73facae207eda12ee133be7d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/streaming/InternalOutputModes.scala#L51-L63
to convert string modes. Can we move the logic of `default` mode there, and reuse it from
`DataFrameWriter`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message