spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] turboFei commented on a change in pull request #25797: [SPARK-29043][Core] Improve the concurrent performance of History Server
Date Fri, 11 Oct 2019 10:54:46 GMT
turboFei commented on a change in pull request #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#discussion_r333935746
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
 ##########
 @@ -561,7 +555,7 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
         .last(newLastScanTime - 1)
         .asScala
         .toList
-      stale.foreach { log =>
+      stale.filterNot(isProcessing(_)).foreach { log =>
 
 Review comment:
   Sorry for late reply, I was on my National Day holiday for past several days.
   
   > Instead of cleaning that log, it will instead be skipped until the next time the cleaner
task run, which may be quote a long time later.
   
   >  but we need to also retry cleaning up these logs sooner, at least sooner than the
interval of cleaner.
   
   It sound a little complex, should we clean these logs with half of  interval of cleaner
later?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message