spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] nonsleepr commented on a change in pull request #26000: [SPARK-29330][CORE][YARN] Allow users to chose the name of Spark Shuffle service
Date Thu, 10 Oct 2019 15:40:33 GMT
nonsleepr commented on a change in pull request #26000: [SPARK-29330][CORE][YARN] Allow users
to chose the name of Spark Shuffle service
URL: https://github.com/apache/spark/pull/26000#discussion_r333594674
 
 

 ##########
 File path: docs/running-on-yarn.md
 ##########
 @@ -492,6 +492,13 @@ To use a custom metrics.properties for the application master and executors,
upd
   If it is not set then the YARN application ID is used.
   </td>
 </tr>
+<tr>
+  <td><code>spark.yarn.shuffle.service.name</code></td>
+  <td><code>spark_shuffle</code></td>
+  <td>
+    Name of the external shuffle service.
 
 Review comment:
   That's what "external" word is for, isn't it?
   Should I reword it as follows?
   > Name of the external shuffle service used by executors.
   *The external service is configured and started by YARN (see [Configuring the External
Shuffle Service](#configuring-the-external-shuffle-service) for details). Apache Spark distribution
uses name `spark_shuffle`, but other distributions (e.g. HDP) might use other names.*

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message