spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] AngersZhuuuu commented on a change in pull request #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
Date Tue, 08 Oct 2019 15:29:07 GMT
AngersZhuuuu commented on a change in pull request #25984: [WIP][SPARK-29308][BUILD] Fix incorrect
dep in dev/deps/spark-deps-hadoop-3.2 
URL: https://github.com/apache/spark/pull/25984#discussion_r332580633
 
 

 ##########
 File path: LICENSE-binary
 ##########
 @@ -320,11 +322,14 @@ com.github.mifmif:generex
 com.github.stephenc.jcip:jcip-annotations
 com.google.code.findbugs:jsr305
 com.google.code.gson:gson
+com.google.flatbuffers:flatbuffers-java
+com.google.guava:guava
 
 Review comment:
   > Wait, where are all these additional license entries coming from? according to the
deps file, the assembly doesn't bring them in. Are you seeing these in the distro jars/ folder?
   
   Yes, it bring guava in dist/jars/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message