spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] AngersZhuuuu edited a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
Date Sun, 06 Oct 2019 03:54:24 GMT
AngersZhuuuu edited a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep
in dev/deps/spark-deps-hadoop-3.2 
URL: https://github.com/apache/spark/pull/25984#issuecomment-538709441
 
 
   Get  `dependency:build-classpath` of parent pom, it will get correct orc jar path(not **nohive**)
 for all module.
   If we get `dependency:build-classpath` for sub-moduleļ¼Œ  it will get wrong  orc jar path(**nohive**).

   
   But profile `hadoop-3.2` truly work, for zookeeper jar in hadoop-2.7 version is 3.4.6,
in hadoop-3.2 version is 3.4.13, it truly works when we get `dependency:build-classpath` of
assembly with profile `hadoop-3.2`. 
   
   
   
   cc @wangyum @srowen @dongjoon-hyun 
   So I change `dev/test-dependencies.sh` to use `-am` with `-pl assembly` to get build result.

   See the change in `dep/deps/spark-deps-hadoop-3.2`
   I have check all change, seem all reasonable.  
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message