spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon opened a new pull request #26021: [SPARK-29286][PYTHON] Uses UTF-8 with 'replace' on errors at Python testing script
Date Fri, 04 Oct 2019 08:56:06 GMT
HyukjinKwon opened a new pull request #26021: [SPARK-29286][PYTHON] Uses UTF-8 with 'replace'
on errors at Python testing script
URL: https://github.com/apache/spark/pull/26021
 
 
   ### What changes were proposed in this pull request?
   
   This PR proposes to let Python 2 uses UTF-8, instead of ASCII, with permissively replacing
non-UDF-8 unicodes into unicode points in Python testing script.
   
   ### Why are the changes needed?
   
   When Python 2 is used to run the Python testing script, with `decode(encoding='ascii')`,
it fails whenever non-ascii codes are printed out.
   
   ### Does this PR introduce any user-facing change?
   
   To dev, it will enable to support to print out non-ASCII characters.
   
   ### How was this patch tested?
   
   Jenkins will test it for our existing test codes. Also, manually tested with UTF-8 output.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message