spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] rednaxelafx commented on a change in pull request #25666: [SPARK-28962][SQL] Provide index argument to filter lambda functions
Date Tue, 01 Oct 2019 19:33:39 GMT
rednaxelafx commented on a change in pull request #25666: [SPARK-28962][SQL] Provide index
argument to filter lambda functions
URL: https://github.com/apache/spark/pull/25666#discussion_r330236082
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
 ##########
 @@ -369,6 +383,9 @@ case class ArrayFilter(
     var i = 0
     while (i < arr.numElements) {
       elementVar.value.set(arr.get(i, elementVar.dataType))
+      if (indexVar.isDefined) {
 
 Review comment:
   @maropu @henrydavidge The best performing way to avoid the per-row check in a non-codegen
setting is to introduce a new expression type, say `ArrayFilterWithIndex`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message