From reviews-return-931127-archive-asf-public=cust-asf.ponee.io@spark.apache.org Sun Sep 29 15:47:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 60A42180626 for ; Sun, 29 Sep 2019 17:47:20 +0200 (CEST) Received: (qmail 93069 invoked by uid 500); 29 Sep 2019 15:47:19 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 93058 invoked by uid 99); 29 Sep 2019 15:47:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 Sep 2019 15:47:19 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] HeartSaVioR commented on issue #25965: [SPARK-26425][SS] Add more constraint checks in file streaming source to avoid checkpoint corruption Message-ID: <156977203970.20559.342251873602492316.gitbox@gitbox.apache.org> Date: Sun, 29 Sep 2019 15:47:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit HeartSaVioR commented on issue #25965: [SPARK-26425][SS] Add more constraint checks in file streaming source to avoid checkpoint corruption URL: https://github.com/apache/spark/pull/25965#issuecomment-536314481 I'm also feeling that commitLog can be also guarded for same, but want to be sure before updating the patch. https://github.com/apache/spark/blob/8167714cab93a5c06c23f92c9077fe8b9677ab28/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala#L566-L572 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org