From reviews-return-923037-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Sep 20 05:17:34 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B599718062C for ; Fri, 20 Sep 2019 07:17:33 +0200 (CEST) Received: (qmail 11108 invoked by uid 500); 20 Sep 2019 05:17:33 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 11097 invoked by uid 99); 20 Sep 2019 05:17:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Sep 2019 05:17:33 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] xuanyuanking commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable Message-ID: <156895665304.16059.2289195014761242141.gitbox@gitbox.apache.org> Date: Fri, 20 Sep 2019 05:17:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit xuanyuanking commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r326473765 ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ########## @@ -1979,6 +1979,13 @@ object SQLConf { .doc("When true, the ArrayExists will follow the three-valued boolean logic.") .booleanConf .createWithDefault(true) + + private[spark] val CENTRAL_REPOSITORY = + ConfigBuilder("spark.sql.centralRepository") + .doc("The default central repository used for downloading Hive jars " + + "in IsolatedClientLoader.") + .stringConf + .createWithDefault("https://repo1.maven.org/maven2") Review comment: That's right, I also test locally without setting any additional remote repo, it will pass. Change the default value and set the config to google mirror in 49ea1cd. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org