From reviews-return-915191-archive-asf-public=cust-asf.ponee.io@spark.apache.org Sat Sep 14 22:23:33 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CAC58180637 for ; Sun, 15 Sep 2019 00:23:32 +0200 (CEST) Received: (qmail 61007 invoked by uid 500); 14 Sep 2019 22:23:32 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 60996 invoked by uid 99); 14 Sep 2019 22:23:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Sep 2019 22:23:32 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] dongjoon-hyun commented on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values Message-ID: <156849981218.15860.10563706390429238766.gitbox@gitbox.apache.org> Date: Sat, 14 Sep 2019 22:23:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dongjoon-hyun commented on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#issuecomment-531518355 Thank you, @HeartSaVioR , @vanzin , @jiangxb1987 , @HyukjinKwon . As @HeartSaVioR pointed [here](https://github.com/apache/spark/pull/25706#discussion_r321926106), the root cause is introduced at 2.4.0 via https://github.com/apache/spark/commit/e3486e1b9556e00bc9c392a5b8440ab366780f9b#diff-f3b410b16818d8f34bb1eb4120a60d51R1102 . Since `branch-2.4` is our LTS branch, can we have this in `branch-2.4`? @HeartSaVioR . Could you make a backporting PR against `branch-2.4`? I guess that will be a reduced backport PR compared with this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org