From reviews-return-907801-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Sep 4 21:14:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E2DEC1804BB for ; Wed, 4 Sep 2019 23:14:11 +0200 (CEST) Received: (qmail 85390 invoked by uid 500); 5 Sep 2019 03:19:41 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 85376 invoked by uid 99); 5 Sep 2019 03:19:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Sep 2019 03:19:41 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] rdblue commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 Message-ID: <156763165070.9527.14867915052524395678.gitbox@gitbox.apache.org> Date: Wed, 04 Sep 2019 21:14:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rdblue commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r320978363 ########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ########## @@ -422,12 +422,30 @@ case class DataSourceStrategy(conf: SQLConf) extends Strategy with Logging with } object DataSourceStrategy { + + /** + * Tries to translate a Catalyst [[Expression]] into data source [[Expression]]. + * + * @return a `Some[catalog.v2.expressions.Expression]` if the input [[Expression]] + * is convertible, otherwise a `None`. + */ + protected[sql] def translateExpression( Review comment: I think this should be located with the Expression classes instead of in the v1 DataSource code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org