spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] sandeep-katta opened a new pull request #25977: [SPARK-29268][SQL]isolationOn value is wrong in case of spark.sql.hive.metastore.jars != builtin
Date Mon, 30 Sep 2019 15:01:36 GMT
sandeep-katta opened a new pull request #25977: [SPARK-29268][SQL]isolationOn value is wrong
in case of spark.sql.hive.metastore.jars != builtin
URL: https://github.com/apache/spark/pull/25977
 
 
   
   
   ### What changes were proposed in this pull request?
   Failed to start **spark-sql** when using **Derby metastore**   and **isolatedLoader** is
enabled
   i.e. spark.sql.hive.metastore.jars=maven or spark.sql.hive.metastore.jars=maven
   
   when `spark.sql.hive.metastore.jars != builtin`  `isolationOn` value is true, it should
be taken from the `isCliSessionState`
   
   
   ### Why are the changes needed?
   
   `isolationOn`  flag is made same as case when `spark.sql.hive.metastore.jars == builtin`
case logic
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   Added UT and also tested manually
   **case 1 :  spark.sql.hive.metastore.jars = classpath**
   ![usingClassPath](https://user-images.githubusercontent.com/35216143/65888973-11985c80-e3be-11e9-9d2a-99aaa6981c52.png)
   
   **case 2:  spark.sql.hive.metastore.jars = maven**
   ![UsingMaven_1](https://user-images.githubusercontent.com/35216143/65889132-558b6180-e3be-11e9-8575-4711918bce1b.png)
   ![UsingMaven_2](https://user-images.githubusercontent.com/35216143/65889141-591ee880-e3be-11e9-996f-0f72f29042aa.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message