spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] wangyum commented on a change in pull request #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples
Date Wed, 25 Sep 2019 09:14:44 GMT
wangyum commented on a change in pull request #25924: [SPARK-29237][SQL][DOC] Avoid usage of
function names in expression examples
URL: https://github.com/apache/spark/pull/25924#discussion_r328014443
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
 ##########
 @@ -1732,9 +1732,9 @@ case class Left(str: Expression, len: Expression, child: Expression)
extends Run
     Examples:
       > SELECT _FUNC_('Spark SQL ');
        10
-      > SELECT CHAR_LENGTH('Spark SQL ');
+      > SELECT _FUNC_('Spark SQL ');
 
 Review comment:
   Yes. +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message