spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type
Date Wed, 25 Sep 2019 08:01:53 GMT
ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL] Spark sql null
type incompatible with hive void type
URL: https://github.com/apache/spark/pull/25085#discussion_r327982049
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
 ##########
 @@ -961,7 +961,11 @@ private[hive] object HiveClientImpl {
   /** Get the Spark SQL native DataType from Hive's FieldSchema. */
   private def getSparkSQLDataType(hc: FieldSchema): DataType = {
     try {
-      CatalystSqlParser.parseDataType(hc.getType)
+      hc.getType match {
+        // SPARK-28313 compatible hive void type
+        case "void" => NullType
 
 Review comment:
   No, hive can not but hive can do `create table t1 as select null as c1`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message