spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins
Date Wed, 25 Sep 2019 03:17:07 GMT
HyukjinKwon commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS]
show tests in SQLQuerySuite correctly in Jenkins
URL: https://github.com/apache/spark/pull/25923#discussion_r327916416
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
 ##########
 @@ -448,7 +448,12 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
     listFilesRecursively(new File(inputFilePath)).flatMap { file =>
       val resultFile = file.getAbsolutePath.replace(inputFilePath, goldenFilePath) + ".out"
       val absPath = file.getAbsolutePath
+
+      // Replacing '.' to '_' is an workaround of sbt bug which removes test name prior to
the
+      // last dot in JUnitXmlReportPlugin.
+      // Please refer https://github.com/sbt/sbt/issues/2949
       val testCaseName = absPath.stripPrefix(inputFilePath).stripPrefix(File.separator)
+        .replace('.', '_')
 
 Review comment:
   @HeartSaVioR, this way affects individual file testing way. This is a bug in SBT and it
affects all tests (see #25630)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message